linux-kernel - Re: [Xen-devel] [PATCH v2] xen: Make VPMU init message look less scary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <57A0636A0200007800101998@prv-mh.provo.novell.com>
Date:	Tue, 02 Aug 2016 01:10:02 -0600
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"Juergen Gross" <JGross@...e.com>
Cc:	<david.vrabel@...rix.com>, <xen-devel@...ts.xenproject.org>,
	<boris.ostrovsky@...cle.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH v2] xen: Make VPMU init message look
 less scary

>>> On 02.08.16 at 08:43, <JGross@...e.com> wrote:
> --- a/arch/x86/xen/pmu.c
> +++ b/arch/x86/xen/pmu.c
> @@ -547,8 +547,11 @@ void xen_pmu_init(int cpu)
>  	return;
>  
>  fail:
> -	pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
> -		cpu, err);
> +	if (err == -EOPNOTSUPP)
> +		pr_info_once("VPMU disabled by hypervisor.\n");
> +	else
> +		pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
> +			cpu, err);

I'm sorry for not already having thought about this for v1, but
what about older hypervisors, where the hypercall would return
-ENOSYS?

Jan