linux-kernel - Re: [PATCH 0293/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160802173411.GB5012@dtor-ws>
Date:	Tue, 2 Aug 2016 10:34:11 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Baole Ni <baolex.ni@...el.com>
Cc:	hal.rosenstock@...il.com, dledford@...hat.com,
	sean.hefty@...el.com, bp@...en8.de, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, rdunlap@...radead.org,
	standby24x7@...il.com, jkosina@...e.com, chuansheng.liu@...el.com
Subject: Re: [PATCH 0293/1285] Replace numeric parameter like 0444 with macro

On Tue, Aug 02, 2016 at 06:57:31PM +0800, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
> 
> Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
> Signed-off-by: Baole Ni <baolex.ni@...el.com>
> ---
>  drivers/input/touchscreen/ili210x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/ili210x.c b/drivers/input/touchscreen/ili210x.c
> index ddf694b..a8a7089 100644
> --- a/drivers/input/touchscreen/ili210x.c
> +++ b/drivers/input/touchscreen/ili210x.c
> @@ -169,7 +169,7 @@ static ssize_t ili210x_calibrate(struct device *dev,
>  
>  	return count;
>  }
> -static DEVICE_ATTR(calibrate, 0644, NULL, ili210x_calibrate);
> +static DEVICE_ATTR(calibrate, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, NULL, ili210x_calibrate);

Here was a bug in the driver that you helpfully carried over. Since we
do not provide "show" method the permissions should be 0200 or S_IWUSR).

Thanks.

-- 
Dmitry