linux-kernel - Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160802.110017.807651313555771477.davem@davemloft.net>
Date:	Tue, 02 Aug 2016 11:00:17 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	john.stultz@...aro.org
Cc:	dsa@...ulusnetworks.com, lorenzo@...gle.com,
	mateusz.bajorski@...ia.com, linux-kernel@...r.kernel.org,
	guodong.xu@...aro.org, dimitrysh@...gle.com, chh@...gle.com,
	ejcaruso@...gle.com, romlem@...gle.com
Subject: Re: [Regression?] fib_rules: Added NLM_F_EXCL support to
 fib_nl_newrule breaks Android userspace

From: John Stultz <john.stultz@...aro.org>
Date: Tue, 2 Aug 2016 10:51:26 -0700

> Yea, it looks like they do in their tree w/ their uid based routing:
> https://android.googlesource.com/kernel/common.git/+/fd2cf795f3ab193752781be7372949ac1780d0ed%5E%21/
> 
> index 96161b8..ce19c5b 100644
> --- a/include/uapi/linux/fib_rules.h
> +++ b/include/uapi/linux/fib_rules.h
> @@ -49,6 +49,8 @@ enum {
>         FRA_TABLE,      /* Extended table id */
>         FRA_FWMASK,     /* mask for netfilter mark */
>         FRA_OIFNAME,
> +       FRA_UID_START,  /* UID range */
> +       FRA_UID_END,
>         __FRA_MAX
>  };
...
> Lorenzo/Rom: Fyi, you've got another upstream feature collision to work out.

It is very difficult for us to take Android networking bug reports
against upstream seriously as long as these kind of situations
continue to exist.

Just FYI...