[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20160802104631.25206-1-baolex.ni@intel.com>
Date: Tue, 2 Aug 2016 18:46:31 +0800
From: Baole Ni <baolex.ni@...el.com>
To: matt@...eblueprint.co.uk, ccross@...roid.com,
keescook@...omium.org, tony.luck@...el.com, m.chehab@...sung.com,
lho@....com, dougthompson@...ssion.com, bp@...en8.de
Cc: linux-kernel@...r.kernel.org, chuansheng.liu@...el.com,
baolex.ni@...el.com, lee.jones@...aro.org
Subject: [PATCH 0172/1285] Replace numeric parameter like 0444 with macro
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
Signed-off-by: Baole Ni <baolex.ni@...el.com>
---
drivers/firmware/google/gsmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c
index f1ab05e..ea451d5 100644
--- a/drivers/firmware/google/gsmi.c
+++ b/drivers/firmware/google/gsmi.c
@@ -129,7 +129,7 @@ struct gsmi_log_entry_type_1 {
*/
#define GSMI_DEFAULT_SPINCOUNT 0x10000
static unsigned int spincount = GSMI_DEFAULT_SPINCOUNT;
-module_param(spincount, uint, 0600);
+module_param(spincount, uint, S_IRUSR | S_IWUSR);
MODULE_PARM_DESC(spincount,
"The number of loop iterations to use when using the spin handshake.");
--
2.9.2
Powered by blists - more mailing lists