linux-kernel - Re: get_maintainer.pl and .mailmap entries with more than 2 addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <xmqqpoprdojp.fsf@gitster.mtv.corp.google.com>
Date:	Tue, 02 Aug 2016 11:16:26 -0700
From:	Junio C Hamano <gitster@...ox.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Florian Mickler <florian@...kler.org>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Shuah Khan <shuah@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>, git <git@...r.kernel.org>
Subject: Re: get_maintainer.pl and .mailmap entries with more than 2 addresses

Joe Perches <joe@...ches.com> writes:

> Hello Florian.
>
> There is at least an oddity with get_maintainer handling of a
> .mailmap entry form.
>
> For instance:
>
> Mauro's .mailmap entry is:
> Mauro Carvalho Chehab <mchehab@...nel.org> <maurochehab@...il.com> <mchehab@...radead.org> <mchehab@...hat.com> <m.chehab@...sung.com> <mchehab@....samsung.com> <mchehab@...pensource.com>
>
> Is this a valid form?

I do not think so, according to "git shortlog --help" (the canonical
source of the document is Documentation/mailmap.txt, but shortlog
doc includes it).  Here is the relevant bits.

    In the simple form, each line in the file consists of the canonical
    real name of an author, whitespace, and an email address used in the
    commit (enclosed by '<' and '>') to map to the name. For example:
    --
            Proper Name <commit@...il.xx>
    --

    The more complex forms are:
    --
            <proper@...il.xx> <commit@...il.xx>
    --
    which allows mailmap to replace only the email part of a commit, and:
    --
            Proper Name <proper@...il.xx> <commit@...il.xx>
    --
    which allows mailmap to replace both the name and the email of a
    commit matching the specified commit email address, and:
    --
            Proper Name <proper@...il.xx> Commit Name <commit@...il.xx>
    --
    which allows mailmap to replace both the name and the email of a
    commit matching both the specified commit name and email address.