| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20160802104816.26485-1-baolex.ni@intel.com> Date: Tue, 2 Aug 2016 18:48:16 +0800 From: Baole Ni <baolex.ni@...el.com> To: airlied@...ux.ie, alexander.deucher@....com, christian.koenig@....com, matt@...eblueprint.co.uk, m.chehab@...sung.com, lho@....com, dougthompson@...ssion.com, bp@...en8.de Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, chuansheng.liu@...el.com, baolex.ni@...el.com, robbat2@...too.org, mst@...hat.com, tiwai@...e.de, architt@...eaurora.org Subject: [PATCH 0191/1285] Replace numeric parameter like 0444 with macro I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com> Signed-off-by: Baole Ni <baolex.ni@...el.com> --- drivers/gpu/drm/drm_probe_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c index 0329080..8fa1d7b 100644 --- a/drivers/gpu/drm/drm_probe_helper.c +++ b/drivers/gpu/drm/drm_probe_helper.c @@ -59,7 +59,7 @@ */ static bool drm_kms_helper_poll = true; -module_param_named(poll, drm_kms_helper_poll, bool, 0600); +module_param_named(poll, drm_kms_helper_poll, bool, S_IRUSR | S_IWUSR); static enum drm_mode_status drm_mode_validate_flag(const struct drm_display_mode *mode, -- 2.9.2
Powered by blists - more mailing lists