linux-kernel - Re: [PATCH 0266/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 2 Aug 2016 21:52:47 +0300
From:	Leon Romanovsky <leon@...nel.org>
To:	Baole Ni <baolex.ni@...el.com>
Cc:	faisal.latif@...el.com, dledford@...hat.com, sean.hefty@...el.com,
	hal.rosenstock@...il.com, bp@...en8.de, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org, chuansheng.liu@...el.com,
	hch@...radead.org, matanb@...lanox.com, markb@...lanox.com,
	jgunthorpe@...idianresearch.com, dean.luick@...el.com
Subject: Re: [PATCH 0266/1285] Replace numeric parameter like 0444 with macro

On Tue, Aug 02, 2016 at 06:54:46PM +0800, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
> 
> Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
> Signed-off-by: Baole Ni <baolex.ni@...el.com>

Looks good,
Reviewed-By: Leon Romanovsky <leonro@...lanox.com>


> ---
>  drivers/infiniband/hw/nes/nes_hw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/nes/nes_hw.c b/drivers/infiniband/hw/nes/nes_hw.c
> index a1c6481..f25c37f 100644
> --- a/drivers/infiniband/hw/nes/nes_hw.c
> +++ b/drivers/infiniband/hw/nes/nes_hw.c
> @@ -41,7 +41,7 @@
>  #include "nes.h"
>  
>  static int wide_ppm_offset;
> -module_param(wide_ppm_offset, int, 0644);
> +module_param(wide_ppm_offset, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
>  MODULE_PARM_DESC(wide_ppm_offset, "Increase CX4 interface clock ppm offset, 0=100ppm (default), 1=300ppm");
>  
>  static u32 crit_err_count;
> -- 
> 2.9.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)