linux-kernel - Re: [PATCH] perf tests: objdump output can contain multi byte chunks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160802194728.GC14639@kernel.org>
Date:	Tue, 2 Aug 2016 16:47:28 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Jan Stancek <jstancek@...hat.com>
Cc:	Adrian Hunter <adrian.hunter@...el.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	linux-kernel@...r.kernel.org, xiakaixu@...wei.com,
	cjashfor@...ux.vnet.ibm.com, dsahern@...il.com, fweisbec@...il.com,
	jolsa@...nel.org, namhyung@...nel.org, paulus@...ba.org,
	a.p.zijlstra@...llo.nl
Subject: Re: [PATCH] perf tests: objdump output can contain multi byte chunks

Em Tue, Aug 02, 2016 at 04:33:16PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Aug 02, 2016 at 04:07:00PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Wed, Jan 13, 2016 at 10:22:04AM +0200, Adrian Hunter escreveu:
> > > Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> > Oops, this one got lost, finally applying...
 
> Ok, it failed for:
 
> ubuntu:16.04-x-armhf: FAIL
> ubuntu:16.04-x-powerpc64: FAIL
> 
> Both are related to, which I am fixing:
> 
>   CC       /tmp/build/perf/tests/code-reading.o
> In file included from /git/linux/tools/perf/util/cpumap.h:9:0,
>                  from /git/linux/tools/perf/util/evsel.h:11,
>                  from /git/linux/tools/perf/util/evlist.h:10,
>                  from tests/code-reading.c:9:
> tests/code-reading.c: In function 'read_via_objdump':
> tests/code-reading.c:197:12: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'size_t {aka unsigned int}' [-Werror=format=]
>    pr_debug("objdump read too few bytes: %lu\n", len);
>             ^
> /git/linux/tools/perf/util/debug.h:18:21: note: in definition of macro 'pr_fmt'
>  #define pr_fmt(fmt) fmt
>                      ^
> tests/code-reading.c:197:3: note: in expansion of macro 'pr_debug'
>    pr_debug("objdump read too few bytes: %lu\n", len);
>    ^

Just use %zd for size_t:

[root@...et ~]# dm ubuntu:16.04-x-armhf ubuntu:16.04-x-powerpc64
1: ubuntu:16.04-x-armhf: Ok
2: ubuntu:16.04-x-powerpc64: Ok
[root@...et ~]#

- Arnaldo