linux-kernel - Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160802212650.GE11239@dhcp22.suse.cz>
Date:	Tue, 2 Aug 2016 23:26:50 +0200
From:	Michal Hocko <mhocko@...nel.org>
To:	Tejun Heo <tj@...nel.org>
Cc:	Oliver Neukum <oneukum@...e.com>,
	Geliang Tang <geliangtang@....com>,
	Johannes Weiner <hannes@...xchg.org>,
	Bhaktipriya Shridhar <bhaktipriya96@...il.com>,
	"GeyslanG.Bem@...yakshetra" <geyslan@...il.com>,
	Masanari Iida <standby24x7@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alan Stern <stern@...land.harvard.edu>,
	Vlastimil Babka <vbabka@...e.cz>,
	Mel Gorman <mgorman@...hsingularity.net>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	Saurabh Karajgaonkar <skarajga@...teon.com>
Subject: Re: [RFC] usb: host: u132-hcd: Remove deprecated
 create_singlethread_workqueue

On Tue 02-08-16 15:02:44, Tejun Heo wrote:
> Hello,
> 
> On Tue, Aug 02, 2016 at 03:29:48PM +0200, Oliver Neukum wrote:
> > Apparently if that is the requirement USB will have to define its own
> > set of flags to use in such contexts. But still the calls as currently
> > executed work. Taking away WQ_MEM_RECLAIM would create danger of
> > introducing a regression. The issue with __GFP_DIRECT_RECLAIM already
> > exists and can be fixed.
> 
> Alright, let's go with WQ_MEM_RECLAIM then.

Agreed, I would just add
/*
 * TODO: make sure that no work item in the rescuer can block on an
 * allocation (so no __GF_DIRECT_RECLAIM)
 */
to all work item functions.
-- 
Michal Hocko
SUSE Labs