linux-kernel - Re: get_maintainer.pl and .mailmap entries with more than 2 addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57A128A6.4040303@kernel.org>
Date:	Tue, 2 Aug 2016 17:11:34 -0600
From:	Shuah Khan <shuah@...nel.org>
To:	Joe Perches <joe@...ches.com>,
	Florian Mickler <florian@...kler.org>
Cc:	Mauro Carvalho Chehab <mchehab@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>, git <git@...r.kernel.org>,
	mchehab@...pensource.com, Shuah Khan <shuahkh@....samsung.com>
Subject: Re: get_maintainer.pl and .mailmap entries with more than 2 addresses

On 08/02/2016 04:26 PM, Joe Perches wrote:
> On Wed, 2016-08-03 at 00:17 +0200, Florian Mickler wrote:
>> cc'd mchehab@...pensource.com  (Mauro, is your kernel.org address up?)
>>
>>  Am Tue, 02 Aug 2016 09:36:21 -0700
>> schrieb Joe Perches <joe@...ches.com>:
>>
>>>
>>> Hello Florian.
>>> There is at least an oddity with get_maintainer handling of a
>>> .mailmap entry form.
>>>
>>> For instance:
>>>
>>> Mauro's .mailmap entry is:
>>> Mauro Carvalho Chehab <mchehab@...nel.org> <maurochehab@...il.com>
>>> <mchehab@...radead.org> <mchehab@...hat.com> <m.chehab@...sung.com>
>>> <mchehab@....samsung.com> <mchehab@...pensource.com>
>>>
>>> Is this a valid form?
>>>
>>> get_maintainer output for Mauro is:
>>>
>>> $ ./scripts/get_maintainer.pl drivers/media/ -f
>>> Mauro Carvalho Chehab <mchehab@...nel.org> <maurochehab@...il.com>
>>> <mchehab@...radead.org> <mchehab@...hat.com> <m.chehab@...sung.com>
>>> <mchehab@....samsung.com> (maintainer:MEDIA INPUT INFRASTRUCTURE
>>> (V4L/DVB))
>>>
>>> I believe the Mauro's and Shuah's .mailmap entries are improper and
>>> should be changed, but I'm not completely aware of git .mailmap
>>> handling and the documentation seems weakly specified.
>>>
>> Hmm.. looking at Mauros last .mailmap commit it seems like your patch is
>> ok for Mauro. 
>>
>> Although <mywing81@...il.com> and <mchehab@...urbo.com.br> are probably
>> missing? (@Mauro) 
>>
>>
>> $ git shortlog | grep "^Mauro C"
>> Mauro Carvalho Chehab (4404):
>> $ git log | grep "^Author:.*Mauro Carvalho Chehab" | sort | uniq -c
>>       2 Author: Mauro Carvalho Chehab <maurochehab@...il.com>
>>     146 Author: Mauro Carvalho Chehab <mchehab@...urbo.com.br>
>>     645 Author: Mauro Carvalho Chehab <mchehab@...radead.org>
>>     794 Author: Mauro Carvalho Chehab <mchehab@....samsung.com>
>>    2015 Author: Mauro Carvalho Chehab <mchehab@...hat.com>
>>     448 Author: Mauro Carvalho Chehab <m.chehab@...sung.com>
>>     353 Author: Mauro Carvalho Chehab <mchehab@...pensource.com>
>>       1 Author: Mauro Carvalho Chehab <mywing81@...il.com>
>>
>>
>>
>> Anyway, from a technical viewpoint your patches seem to fix
>> the .mailmap entry as the author intended. (See Junio's Email for the
>> documantation part) 
>> But I would wait for the ack from Mauro and Shuah. 
> 
> As far as I understand, a single entry with just their
> name and preferred email address would work too because
> the name parts are all spelled identically.
> 
> 

I am fine with change to my entry. Thanks for fixing it.

Acked-by: Shuah Khan <shuahkh@....samsung.com>

thanks,
-- Shuah