linux-kernel - [PATCH 0057/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20160802103734.17562-1-baolex.ni@intel.com>
Date:	Tue,  2 Aug 2016 18:37:34 +0800
From:	Baole Ni <baolex.ni@...el.com>
To:	tj@...nel.org, rjw@...ysocki.net, lenb@...nel.org, x86@...nel.org,
	hpa@...or.com
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	chuansheng.liu@...el.com, baolex.ni@...el.com, travis@....com
Subject: [PATCH 0057/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
Signed-off-by: Baole Ni <baolex.ni@...el.com>
---
 drivers/ata/libahci.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index 71b0719..7d833db 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -51,10 +51,10 @@ static int ahci_skip_host_reset;
 int ahci_ignore_sss;
 EXPORT_SYMBOL_GPL(ahci_ignore_sss);
 
-module_param_named(skip_host_reset, ahci_skip_host_reset, int, 0444);
+module_param_named(skip_host_reset, ahci_skip_host_reset, int, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(skip_host_reset, "skip global host reset (0=don't skip, 1=skip)");
 
-module_param_named(ignore_sss, ahci_ignore_sss, int, 0444);
+module_param_named(ignore_sss, ahci_ignore_sss, int, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(ignore_sss, "Ignore staggered spinup flag (0=don't ignore, 1=ignore)");
 
 static int ahci_set_lpm(struct ata_link *link, enum ata_lpm_policy policy,
@@ -190,14 +190,14 @@ EXPORT_SYMBOL_GPL(ahci_pmp_retry_srst_ops);
 
 static bool ahci_em_messages __read_mostly = true;
 EXPORT_SYMBOL_GPL(ahci_em_messages);
-module_param(ahci_em_messages, bool, 0444);
+module_param(ahci_em_messages, bool, S_IRUSR | S_IRGRP | S_IROTH);
 /* add other LED protocol types when they become supported */
 MODULE_PARM_DESC(ahci_em_messages,
 	"AHCI Enclosure Management Message control (0 = off, 1 = on)");
 
 /* device sleep idle timeout in ms */
 static int devslp_idle_timeout __read_mostly = 1000;
-module_param(devslp_idle_timeout, int, 0644);
+module_param(devslp_idle_timeout, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(devslp_idle_timeout, "device sleep idle timeout");
 
 static void ahci_enable_ahci(void __iomem *mmio)
-- 
2.9.2