linux-kernel - [PATCH 0288/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20160802105701.569-1-baolex.ni@intel.com>
Date:	Tue,  2 Aug 2016 18:57:01 +0800
From:	Baole Ni <baolex.ni@...el.com>
To:	michael.hennerich@...log.com, dmitry.torokhov@...il.com,
	hal.rosenstock@...il.com, dledford@...hat.com,
	sean.hefty@...el.com, bp@...en8.de
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	chuansheng.liu@...el.com, baolex.ni@...el.com
Subject: [PATCH 0288/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
Signed-off-by: Baole Ni <baolex.ni@...el.com>
---
 drivers/input/touchscreen/ad7877.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c
index 9c250ae..85e6135 100644
--- a/drivers/input/touchscreen/ad7877.c
+++ b/drivers/input/touchscreen/ad7877.c
@@ -497,7 +497,7 @@ static ssize_t ad7877_disable_store(struct device *dev,
 	return count;
 }
 
-static DEVICE_ATTR(disable, 0664, ad7877_disable_show, ad7877_disable_store);
+static DEVICE_ATTR(disable, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, ad7877_disable_show, ad7877_disable_store);
 
 static ssize_t ad7877_dac_show(struct device *dev,
 				     struct device_attribute *attr, char *buf)
@@ -527,7 +527,7 @@ static ssize_t ad7877_dac_store(struct device *dev,
 	return count;
 }
 
-static DEVICE_ATTR(dac, 0664, ad7877_dac_show, ad7877_dac_store);
+static DEVICE_ATTR(dac, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, ad7877_dac_show, ad7877_dac_store);
 
 static ssize_t ad7877_gpio3_show(struct device *dev,
 				     struct device_attribute *attr, char *buf)
@@ -558,7 +558,7 @@ static ssize_t ad7877_gpio3_store(struct device *dev,
 	return count;
 }
 
-static DEVICE_ATTR(gpio3, 0664, ad7877_gpio3_show, ad7877_gpio3_store);
+static DEVICE_ATTR(gpio3, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, ad7877_gpio3_show, ad7877_gpio3_store);
 
 static ssize_t ad7877_gpio4_show(struct device *dev,
 				     struct device_attribute *attr, char *buf)
@@ -589,7 +589,7 @@ static ssize_t ad7877_gpio4_store(struct device *dev,
 	return count;
 }
 
-static DEVICE_ATTR(gpio4, 0664, ad7877_gpio4_show, ad7877_gpio4_store);
+static DEVICE_ATTR(gpio4, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, ad7877_gpio4_show, ad7877_gpio4_store);
 
 static struct attribute *ad7877_attributes[] = {
 	&dev_attr_temp1.attr,
-- 
2.9.2