linux-kernel - [PATCH 0969/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20160802120344.14661-1-baolex.ni@intel.com>
Date:	Tue,  2 Aug 2016 20:03:44 +0800
From:	Baole Ni <baolex.ni@...el.com>
To:	gregkh@...uxfoundation.org, jslaby@...e.com, m.chehab@...sung.com,
	m.szyprowski@...sung.com, kyungmin.park@...sung.com,
	k.kozlowski@...sung.com
Cc:	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	chuansheng.liu@...el.com, baolex.ni@...el.com,
	andriy.shevchenko@...ux.intel.com,
	wan.ahmad.zainie.wan.mohamad@...el.com, mail@...iej.szmigiero.name,
	matwey@....msu.ru
Subject: [PATCH 0969/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
Signed-off-by: Baole Ni <baolex.ni@...el.com>
---
 drivers/tty/serial/kgdb_nmi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/kgdb_nmi.c b/drivers/tty/serial/kgdb_nmi.c
index 117df15..522c980 100644
--- a/drivers/tty/serial/kgdb_nmi.c
+++ b/drivers/tty/serial/kgdb_nmi.c
@@ -31,7 +31,7 @@
 #include <linux/kdb.h>
 
 static int kgdb_nmi_knock = 1;
-module_param_named(knock, kgdb_nmi_knock, int, 0600);
+module_param_named(knock, kgdb_nmi_knock, int, S_IRUSR | S_IWUSR);
 MODULE_PARM_DESC(knock, "if set to 1 (default), the special '$3#33' command " \
 			"must be used to enter the debugger; when set to 0, " \
 			"hitting return key is enough to enter the debugger; " \
@@ -39,7 +39,7 @@ MODULE_PARM_DESC(knock, "if set to 1 (default), the special '$3#33' command " \
 			"upon NMI");
 
 static char *kgdb_nmi_magic = "$3#33";
-module_param_named(magic, kgdb_nmi_magic, charp, 0600);
+module_param_named(magic, kgdb_nmi_magic, charp, S_IRUSR | S_IWUSR);
 MODULE_PARM_DESC(magic, "magic sequence to enter NMI debugger (default $3#33)");
 
 static atomic_t kgdb_nmi_num_readers = ATOMIC_INIT(0);
-- 
2.9.2