linux-kernel - Re: [PATCH 2/2 v4] perf sched: adapt TASK_STATE_TO_CHAR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160802221743.ecc77f0774d2fd1226b149fb@kernel.org>
Date:	Tue, 2 Aug 2016 22:17:43 +0900
From:	Masami Hiramatsu <mhiramat@...nel.org>
To:	David Ahern <dsahern@...il.com>
Cc:	Tomoki Sekiyama <tomoki.sekiyama.qu@...achi.com>,
	linux-kernel@...r.kernel.org, ltc-kernel@...ml.intra.hitachi.co.jp,
	masumi.moritani.ju@...achi.com, Jiri Olsa <jolsa@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [PATCH 2/2 v4] perf sched: adapt TASK_STATE_TO_CHAR_STR to the
 latest kernel

On Mon, 1 Aug 2016 07:58:19 -0600
David Ahern <dsahern@...il.com> wrote:

> On 7/31/16 10:30 PM, Tomoki Sekiyama wrote:
> > Update TASK_STATE_TO_CHAR_STR macro to one from sched.h in the latest
> > kernel, where 'N' and 'n' are introduced, 'X' and 'Z' are swapped.
> >
> > Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama.qu@...achi.com>
> > Fixes: cdce9d738b91e ("perf sched: Add sched latency profiling")
> 
> Wrong Fixes tag for this change.
> 
> This is really an update based on kernel changes, the last one being 
> 7dc603c9028ea.

Except for the above mistake, I'm also OK for the code.

Thanks,

> 
> 
> > Cc: Jiri Olsa <jolsa@...nel.org>
> > Cc: David Ahern <dsahern@...il.com>
> > Cc: Namhyung Kim <namhyung@...nel.org>
> > Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> > Cc: Masami Hiramatsu <mhiramat@...nel.org>
> > ---
> > Changes from v3:
> >   Added Fixes:
> >   Split patch into 2 pieces.
> >
> >  tools/perf/builtin-sched.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> > index ce9bef6..5776263 100644
> > --- a/tools/perf/builtin-sched.c
> > +++ b/tools/perf/builtin-sched.c
> > @@ -70,7 +70,7 @@ struct sched_atom {
> >  	struct task_desc	*wakee;
> >  };
> >
> > -#define TASK_STATE_TO_CHAR_STR "RSDTtZXxKWP"
> > +#define TASK_STATE_TO_CHAR_STR "RSDTtXZxKWPNn"
> >
> >  enum thread_state {
> >  	THREAD_SLEEPING = 0,
> >
> 
> Acked-by: David Ahern <dsahern@...il.com>


-- 
Masami Hiramatsu <mhiramat@...nel.org>