linux-kernel - Re: [PATCH 1082/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 2 Aug 2016 09:27:02 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Baole Ni <baolex.ni@...el.com>
Cc:	sjenning@...hat.com, jiangshanlai@...il.com,
	mathieu.desnoyers@...icios.com, m.chehab@...sung.com,
	gregkh@...uxfoundation.org, m.szyprowski@...sung.com,
	kyungmin.park@...sung.com, k.kozlowski@...sung.com,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	chuansheng.liu@...el.com, oleg@...hat.com,
	gang.chen.5i5j@...il.com, mhocko@...e.com, koct9i@...il.com,
	aarcange@...hat.com, aryabinin@...tuozzo.com
Subject: Re: [PATCH 1082/1285] Replace numeric parameter like 0444 with
 macro

On Tue,  2 Aug 2016 20:14:48 +0800
Baole Ni <baolex.ni@...el.com> wrote:

> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
> 

NACK!

I find 0444 more readable than S_IRUSR | S_IRGRP | S_IROTH.

-- Steve

> Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
> Signed-off-by: Baole Ni <baolex.ni@...el.com>
> ---
>  mm/zswap.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/zswap.c b/mm/zswap.c
> index 275b22c..aede3ee 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -78,7 +78,7 @@ static u64 zswap_duplicate_entry;
>  
>  /* Enable/disable zswap (disabled by default) */
>  static bool zswap_enabled;
> -module_param_named(enabled, zswap_enabled, bool, 0644);
> +module_param_named(enabled, zswap_enabled, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
>  
>  /* Crypto compressor to use */
>  #define ZSWAP_COMPRESSOR_DEFAULT "lzo"
> @@ -91,7 +91,7 @@ static struct kernel_param_ops zswap_compressor_param_ops = {
>  	.free =		param_free_charp,
>  };
>  module_param_cb(compressor, &zswap_compressor_param_ops,
> -		&zswap_compressor, 0644);
> +		&zswap_compressor, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
>  
>  /* Compressed storage zpool to use */
>  #define ZSWAP_ZPOOL_DEFAULT "zbud"
> @@ -102,11 +102,11 @@ static struct kernel_param_ops zswap_zpool_param_ops = {
>  	.get =		param_get_charp,
>  	.free =		param_free_charp,
>  };
> -module_param_cb(zpool, &zswap_zpool_param_ops, &zswap_zpool_type, 0644);
> +module_param_cb(zpool, &zswap_zpool_param_ops, &zswap_zpool_type, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
>  
>  /* The maximum percentage of memory that the compressed pool can occupy */
>  static unsigned int zswap_max_pool_percent = 20;
> -module_param_named(max_pool_percent, zswap_max_pool_percent, uint, 0644);
> +module_param_named(max_pool_percent, zswap_max_pool_percent, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
>  
>  /*********************************
>  * data structures