lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 2 Aug 2016 09:26:52 -0400 From: Steven Rostedt <rostedt@...dmis.org> To: Baole Ni <baolex.ni@...el.com> Cc: jbaron@...mai.com, jiangshanlai@...il.com, mathieu.desnoyers@...icios.com, m.chehab@...sung.com, gregkh@...uxfoundation.org, m.szyprowski@...sung.com, kyungmin.park@...sung.com, k.kozlowski@...sung.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org, akpm@...ux-foundation.org, kirill.shutemov@...ux.intel.com, oleg@...hat.com, gang.chen.5i5j@...il.com, mhocko@...e.com, koct9i@...il.com, aarcange@...hat.com, aryabinin@...tuozzo.com, chuansheng.liu@...el.com Subject: Re: [PATCH 1081/1285] Replace numeric parameter like 0444 with macro On Tue, 2 Aug 2016 20:14:43 +0800 Baole Ni <baolex.ni@...el.com> wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > NACK! I find 0444 more readable than S_IRUSR | S_IRGRP | S_IROTH. -- Steve > Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com> > Signed-off-by: Baole Ni <baolex.ni@...el.com> > --- > mm/mmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index de2c176..fad009c 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -67,7 +67,7 @@ int mmap_rnd_compat_bits __read_mostly = CONFIG_ARCH_MMAP_RND_COMPAT_BITS; > #endif > > static bool ignore_rlimit_data; > -core_param(ignore_rlimit_data, ignore_rlimit_data, bool, 0644); > +core_param(ignore_rlimit_data, ignore_rlimit_data, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > > static void unmap_region(struct mm_struct *mm, > struct vm_area_struct *vma, struct vm_area_struct *prev,
Powered by blists - more mailing lists