linux-kernel - Re: [PATCH 1271/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4bc851b0-73a2-f206-09e7-e6cc1f60cb9f@ti.com>
Date:	Tue, 2 Aug 2016 16:25:15 +0300
From:	Peter Ujfalusi <peter.ujfalusi@...com>
To:	Baole Ni <baolex.ni@...el.com>, <jarkko.nikula@...mer.com>,
	<lgirdwood@...il.com>, <broonie@...nel.org>, <perex@...ex.cz>,
	<tiwai@...e.com>, <davem@...emloft.net>,
	<m.szyprowski@...sung.com>, <kyungmin.park@...sung.com>,
	<k.kozlowski@...sung.com>
CC:	<alsa-devel@...a-project.org>, <linux-omap@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <chuansheng.liu@...el.com>,
	<fabio.estevam@....com>, <linus.walleij@...aro.org>,
	<zidan.wang@...escale.com>, <sachinpandhare@...il.com>,
	<lars@...afoo.de>
Subject: Re: [PATCH 1271/1285] Replace numeric parameter like 0444 with macro

On 08/02/16 15:33, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
> 
> Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
> Signed-off-by: Baole Ni <baolex.ni@...el.com>
> ---
>  sound/soc/omap/mcbsp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
> index 4a16e77..3938336 100644
> --- a/sound/soc/omap/mcbsp.c
> +++ b/sound/soc/omap/mcbsp.c
> @@ -857,7 +857,7 @@ unlock:
>  	return size;
>  }
>  
> -static DEVICE_ATTR(dma_op_mode, 0644, dma_op_mode_show, dma_op_mode_store);
> +static DEVICE_ATTR(dma_op_mode, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, dma_op_mode_show, dma_op_mode_store);

I prefer to have the octal representation, more compact, easier to understand.

>  
>  static const struct attribute *additional_attrs[] = {
>  	&dev_attr_max_tx_thres.attr,
> @@ -926,7 +926,7 @@ out:
>  	return size;
>  }
>  
> -static DEVICE_ATTR(st_taps, 0644, st_taps_show, st_taps_store);
> +static DEVICE_ATTR(st_taps, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, st_taps_show, st_taps_store);
>  
>  static const struct attribute *sidetone_attrs[] = {
>  	&dev_attr_st_taps.attr,
> 

-- 
Péter