linux-kernel - Re: [PATCH 0096/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160802130913.jncj2lteaie7mkep@mac>
Date:	Tue, 2 Aug 2016 15:09:13 +0200
From:	Roger Pau Monné <roger.pau@...rix.com>
To:	Baole Ni <baolex.ni@...el.com>
CC:	<konrad.wilk@...cle.com>, <pavel@....cz>,
	<gregkh@...uxfoundation.org>, <hpa@...or.com>, <x86@...nel.org>,
	<xen-devel@...ts.xenproject.org>, <linux-kernel@...r.kernel.org>,
	<chuansheng.liu@...el.com>, <martin.petersen@...cle.com>,
	<kent.overstreet@...il.com>
Subject: Re: [PATCH 0096/1285] Replace numeric parameter like 0444 with macro

On Tue, Aug 02, 2016 at 06:40:21PM +0800, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
> 
> Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
> Signed-off-by: Baole Ni <baolex.ni@...el.com>

Acked-by: Roger Pau Monné <roger.pau@...rix.com>