linux-kernel - Re: [PATCH 0063/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <A2C6171B-DD7F-4C31-B032-0F3DC6B3F161@holtmann.org>
Date:	Tue, 2 Aug 2016 15:58:10 +0200
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Baole Ni <baolex.ni@...el.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	tj@...nel.org, lenb@...nel.org, X86 ML <x86@...nel.org>,
	hpa@...or.com, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org, chuansheng.liu@...el.com,
	travis@....com
Subject: Re: [PATCH 0063/1285] Replace numeric parameter like 0444 with macro

Hi Steven,

>>>> static int all;
>>>> -module_param(all, int, 0444);
>>>> +module_param(all, int, S_IRUSR | S_IRGRP | S_IROTH);
>>> 
>>>   There's S_IRUGO for this case, no?
> 
> Sure, and honestly, I understand what 0444 is better than seeing:
> 
>  S_IRUSR | S_IRGRP | SIROTH
> 
> Heck, 0444 is more understandable to me than S_IRUGO, because honestly, those
> macros are just as cryptic as 0444 is. Working with Unix/Linux systems since
> 1991, I understand the octo numbers very well. And I'm sure most other people
> do to. Any file that I'm Cc'd on here will get an automatic NAK from me.

you are not helping to reduce the 1285 patch bomb. Your automatic replies make it worse now ;)

Regards

Marcel