linux-kernel - Re: [PATCH] mips: lantiq: fix irq_chip name to not land in new parent field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160803055653.GG15910@linux-mips.org>
Date:	Wed, 3 Aug 2016 07:56:53 +0200
From:	Ralf Baechle <ralf@...ux-mips.org>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	linux-kernel@...r.kernel.org, Jon Hunter <jonathanh@...dia.com>,
	Kevin Hilman <khilman@...libre.com>,
	Marc Zyngier <marc.zyngier@....com>,
	John Crispin <john@...ozen.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-mips@...ux-mips.org,
	Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
Subject: Re: [PATCH] mips: lantiq: fix irq_chip name to not land in new
 parent field

On Tue, Aug 02, 2016 at 02:54:47PM -0400, Paul Gortmaker wrote:

> As of commit be45beb2df69 ("genirq: Add runtime power management
> support for IRQ chips") the irq_chip struct got a struct *device
> parent_device field added to it.  However, it was added at the
> beginning of the struct, which previously was the "name" entry.
> 
> The driver here was using a mix of ordered struct init entries and
> named init entries.  It was supplying the name assuming it was the 1st
> in the order, and hence when that became a struct *device we get:
> 
> arch/mips/lantiq/irq.c:209:2: warning: initialization from incompatible pointer type [enabled by default]
> arch/mips/lantiq/irq.c:209:2: warning: (near initialization for 'ltq_irq_type.parent_device') [enabled by default]
> arch/mips/lantiq/irq.c:219:2: warning: initialization from incompatible pointer type [enabled by default]
> arch/mips/lantiq/irq.c:219:2: warning: (near initialization for 'ltq_eiu_type.parent_device') [enabled by default]
> 
> While not runtime tested, I can't imagine trying to dereference a
> a struct device field from a char string will end well.
> 
> Here we've used named element init entries for the name string as well
> to fix it.
> 
> Fixes: be45beb2df69 ("genirq: Add runtime power management support for IRQ chips")
> Cc: Jon Hunter <jonathanh@...dia.com>
> Cc: Kevin Hilman <khilman@...libre.com>
> Cc: Marc Zyngier <marc.zyngier@....com>
> Cc: John Crispin <john@...ozen.org>
> Cc: Ralf Baechle <ralf@...ux-mips.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: linux-mips@...ux-mips.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Thanks for the patch but I've already applied the identical patch
https://patchwork.linux-mips.org/patch/13684/.

  Ralf