linux-kernel - Re: [PATCH] MIPS: Loongson1B: Provide DMA filter callbacks via platform data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160803061419.GH15910@linux-mips.org>
Date:	Wed, 3 Aug 2016 08:14:20 +0200
From:	Ralf Baechle <ralf@...ux-mips.org>
To:	Keguang Zhang <keguang.zhang@...il.com>
Cc:	linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: Loongson1B: Provide DMA filter callbacks via
 platform data

On Sat, May 28, 2016 at 05:51:52PM +0800, Keguang Zhang wrote:

> diff --git a/arch/mips/include/asm/mach-loongson32/nand.h b/arch/mips/include/asm/mach-loongson32/nand.h
> index e274912..a1f8704 100644
> --- a/arch/mips/include/asm/mach-loongson32/nand.h
> +++ b/arch/mips/include/asm/mach-loongson32/nand.h
> @@ -21,10 +21,9 @@ struct plat_ls1x_nand {
>  
>  	int hold_cycle;
>  	int wait_cycle;
> +	bool (*dma_filter)(struct dma_chan *chan, void *param);
>  };
>  
>  extern struct plat_ls1x_nand ls1b_nand_pdata;
>  
> -bool ls1x_dma_filter_fn(struct dma_chan *chan, void *param);
> -
>  #endif /* __ASM_MACH_LOONGSON32_NAND_H */
> diff --git a/arch/mips/loongson32/ls1b/board.c b/arch/mips/loongson32/ls1b/board.c
> index 38a1d40..0a57337 100644
> --- a/arch/mips/loongson32/ls1b/board.c
> +++ b/arch/mips/loongson32/ls1b/board.c
> @@ -38,6 +38,7 @@ struct plat_ls1x_nand ls1x_nand_pdata = {
>  	.nr_parts	= ARRAY_SIZE(ls1x_nand_parts),
>  	.hold_cycle	= 0x2,
>  	.wait_cycle	= 0xc,
> +	.dma_filter	= ls1x_dma_filter,
>  };

Without the DMA driver which Vinod has requested changes for this
patch will result in build errors.  It will also result in a build
error if CONFIG_LOONGSON1_DMA is disabled.

  Ralf