linux-kernel - Re: [PATCH 1/5] bfa: mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 03 Aug 2016 09:46:01 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	kbuild test robot <lkp@...el.com>
Cc:	kbuild-all@...org, Anil Gurumurthy <anil.gurumurthy@...gic.com>,
	Sudarsana Kalluru <sudarsana.kalluru@...gic.com>,
	"James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
	"Martin K . Petersen" <martin.petersen@...cle.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Baoyou Xie <baoyou.xie@...aro.org>
Subject: Re: [PATCH 1/5] bfa: mark symbols static where possible

On Wednesday, August 3, 2016 12:45:50 PM CEST kbuild test robot wrote:
> All errors (new ones prefixed by >>):
> 
>    drivers/scsi/bfa/bfad.c: In function 'bfad_drv_uninit':
> >> drivers/scsi/bfa/bfad.c:888:2: error: implicit declaration of function 'bfa_isr_disable' [-Werror=implicit-function-declaration]
>      bfa_isr_disable(&bfad->bfa);
>      ^
>    cc1: some warnings being treated as errors
> 

Ah right: This is called in a function that gets removed in patch 5,
after which it is actually local. I made a mistake here when I went
through a repeated search for local functions.

I'll wait for other comments first before I send a fixed version.

	Arnd