linux-kernel - Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 02 Aug 2016 18:04:31 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	lorenzo@...gle.com
Cc:	john.stultz@...aro.org, dsa@...ulusnetworks.com,
	mateusz.bajorski@...ia.com, linux-kernel@...r.kernel.org,
	guodong.xu@...aro.org, dimitrysh@...gle.com, chh@...gle.com,
	ejcaruso@...gle.com, romlem@...gle.com
Subject: Re: [Regression?] fib_rules: Added NLM_F_EXCL support to
 fib_nl_newrule breaks Android userspace

From: Lorenzo Colitti <lorenzo@...gle.com>
Date: Wed, 3 Aug 2016 09:58:09 +0900

> The problem is that the UID routing patches were never accepted
> upstream, and because FRA_xxx and RTA_xxx are enums, there's no safe
> way to add a new value out of tree like there would be with other
> identifiers such as setsockopt values.
> 
> I'm going to make another attempt to upstream the UID routing code
> soon. If that doesn't make it, then we could attempt to reserve a
> couple RTA_xxx and FRA_xxx values for local use.

If upstream rejects the feature, it's because you'll be given a
suggested alternative implementation in order to achieve your
goals.

In that respect, it is inappropriate to expect that we will "reserve"
netlink ID space for such a feature that is rejected in that manner
upstream.