linux-kernel - Re: [RFC PATCH 3/4] usb: typec: USB Type-C Port Manager (tcpm)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1470215880.4612.3.camel@suse.com>
Date:	Wed, 03 Aug 2016 11:18:00 +0200
From:	Oliver Neukum <oneukum@...e.com>
To:	Guenter Roeck <groeck@...omium.org>
Cc:	Felipe Balbi <felipe.balbi@...ux.intel.com>,
	Bin Gao <bin.gao@...el.com>,
	Chandra Sekhar Anagani <chandra.sekhar.anagani@...el.com>,
	Pranav Tipnis <pranav.tipnis@...el.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	Bruce Ashfield <bruce.ashfield@...driver.com>
Subject: Re: [RFC PATCH 3/4] usb: typec: USB Type-C Port Manager (tcpm)

On Tue, 2016-08-02 at 13:32 -0700, Guenter Roeck wrote:
> +static int tcpm_set_polarity(struct tcpm_port *port,
> +                            enum typec_cc_polarity polarity)
> +{
> +       tcpm_log(port, "polarity %d", polarity);
> +
> +       port->polarity = polarity;
> +
> +       return port->tcpc->set_polarity(port->tcpc, port->polarity);
> +}

Here you don't care about the result.

> +
> +static int tcpm_set_vconn(struct tcpm_port *port, bool enable)
> +{
> +       int ret = 0;
> +
> +       tcpm_log(port, "vconn:=%d", enable);
> +
> +       ret = port->tcpc->set_vconn(port->tcpc, enable);
> +       if (!ret) {
> +               port->con.vconn_role = enable ? TYPEC_SOURCE
> +                                             : TYPEC_SINK;
> +               typec_set_vconn_role(port->typec_port,
> port->con.vconn_role);
> +       }
> +
> +       return ret;
> +}

But here you do. Which is right?

	Regards
		Oliver