linux-kernel - [PATCH] fix debugfs_simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1608031356380.2991@hadrien>
Date:	Wed, 3 Aug 2016 13:57:37 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Andi Kleen <andi@...stfloor.org>
cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: [PATCH] fix debugfs_simple_attr.cocci warnings (fwd)

I know nothing about the issues behind this, but I'm forwarding it in case
it's useful.

julia

---------- Forwarded message ----------
Date: Wed, 3 Aug 2016 13:26:56 +0800
From: kbuild test robot <fengguang.wu@...el.com>
To: kbuild@...org
Cc: Julia Lawall <julia.lawall@...6.fr>
Subject: [PATCH] fix debugfs_simple_attr.cocci warnings

CC: kbuild-all@...org
In-Reply-To: <1470170405-21530-1-git-send-email-andi@...stfloor.org>
TO: Andi Kleen <andi@...stfloor.org>
CC: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>
CC: linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>

kernel/panic.c:561:0-23: WARNING: clear_warn_once_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE

 Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
 for debugfs files.

Semantic patch information:
 Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
 imposes some significant overhead as compared to
 DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().

Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci

CC: Andi Kleen <ak@...ux.intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---

Please take the patch only if it's a positive warning. Thanks!

 panic.c |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -558,16 +558,14 @@ static int clear_warn_once_set(void *dat
 	return 0;
 }

-DEFINE_SIMPLE_ATTRIBUTE(clear_warn_once_fops,
-			NULL,
-                        clear_warn_once_set,
-		        "%lld\n");
+DEFINE_DEBUGFS_ATTRIBUTE(clear_warn_once_fops, NULL, clear_warn_once_set,
+			 "%lld\n");

 static __init int register_warn_debugfs(void)
 {
 	/* Don't care about failure */
-	debugfs_create_file("clear_warn_once", 0644, NULL,
-			    NULL, &clear_warn_once_fops);
+	debugfs_create_file_unsafe("clear_warn_once", 0644, NULL, NULL,
+				   &clear_warn_once_fops);
 	return 0;
 }