linux-kernel - Re: [PATCH] arm64: dts: rockchip: Provide power-domains for sd/sdio/emmc controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5792766.oYNWZEQPkG@diego>
Date:	Wed, 03 Aug 2016 14:07:42 +0200
From:	Heiko Stübner <heiko@...ech.de>
To:	Shawn Lin <shawn.lin@...k-chips.com>
Cc:	Doug Anderson <dianders@...omium.org>,
	Brian Norris <briannorris@...omium.org>,
	Elaine Zhang <zhangqing@...k-chips.com>,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Provide power-domains for sd/sdio/emmc controllers

Hi Shawn,

Am Montag, 1. August 2016, 16:41:14 schrieb Shawn Lin:
> The PM domain will be "powered on" once we have registered our PM domain
> with genpd and when the device (dw_mmc etc) gets attached to the domain.
> The attach occurs when the platform bus'->probe() function get invoked
> for the device.
> 
> Due to this, we should be able to deploy genpd support by adding the
> phandle of related power-domains without first having to deploying
> runtime PM support in the related drivers.
> 
> Let's do this in case of taking risk of accessing controller when the
> genpd is in "power off" status as the genpd will turn off all the
> power domains which are the referenced by drivers.
> 
> Signed-off-by: Shawn Lin <shawn.lin@...k-chips.com>

you're missing the subnodes below power: power-controller defining the power-
domains, - including the needed clocks. Thus currently you end up defering 
probe of the emmc and friends indefinitly.

Ideally do it in this patch together with the assignment.

Thanks
Heiko