[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1470225791-16613-2-git-send-email-wagi@monom.org>
Date: Wed, 3 Aug 2016 14:03:08 +0200
From: Daniel Wagner <wagi@...om.org>
To: Wolfram Sang <wsa@...-dreams.de>
Cc: Beniamino Galvani <b.galvani@...il.com>,
Kamal Dasu <kdasu.kdev@...il.com>, Ray Jui <rjui@...adcom.com>,
Tim Kryger <tim.kryger@...aro.org>,
linux-amlogic@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org,
bcm-kernel-feedback-list@...adcom.com,
linux-kernel@...r.kernel.org,
Daniel Wagner <daniel.wagner@...-carit.de>
Subject: [PATCH v0 1/4] i2c: bcm-iproc: Use complete() instead of complete_all()
From: Daniel Wagner <daniel.wagner@...-carit.de>
There is only one waiter for the completion, therefore there
is no need to use complete_all(). Let's make that clear by
using complete() instead of complete_all().
The usage pattern of the completion is:
bcm_iproc_i2c_xfer_single_msg()
reinit_completion()
...
(activate the transfer)
...
wait_for_completion_timeout()
Signed-off-by: Daniel Wagner <daniel.wagner@...-carit.de>
---
drivers/i2c/busses/i2c-bcm-iproc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c
index 19c8438..95f7cac 100644
--- a/drivers/i2c/busses/i2c-bcm-iproc.c
+++ b/drivers/i2c/busses/i2c-bcm-iproc.c
@@ -158,7 +158,7 @@ static irqreturn_t bcm_iproc_i2c_isr(int irq, void *data)
if (status & BIT(IS_M_START_BUSY_SHIFT)) {
iproc_i2c->xfer_is_done = 1;
- complete_all(&iproc_i2c->done);
+ complete(&iproc_i2c->done);
}
writel(status, iproc_i2c->base + IS_OFFSET);
--
2.7.4
Powered by blists - more mailing lists