linux-kernel - Re: [PATCH 0210/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160803152332.GA8124@kozik-book>
Date:	Wed, 3 Aug 2016 17:23:32 +0200
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Baole Ni <baolex.ni@...el.com>
Cc:	airlied@...ux.ie, kyungmin.park@...sung.com, kgene@...nel.org,
	k.kozlowski@...sung.com, dougthompson@...ssion.com, bp@...en8.de,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	airlied@...hat.com, daniel.vetter@...ll.ch, treding@...dia.com,
	alexander.deucher@....com, ville.syrjala@...ux.intel.com,
	chuansheng.liu@...el.com
Subject: Re: [PATCH 0210/1285] Replace numeric parameter like 0444 with macro

On Tue, Aug 02, 2016 at 06:50:01PM +0800, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
> 
> Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
> Signed-off-by: Baole Ni <baolex.ni@...el.com>
> ---
>  drivers/gpu/drm/qxl/qxl_drv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I got almost 1000 patches out of your mail bomb. For all of them: NACK.
Other people pointed actual reasons (title, readability, cc-list). The
commit msg should be also written in a more readable way.

Anyway, in Intel there are a lot of people having kernel contributions
so it is a shame that you didn't ask them for advice how to do it...

BR,
Krzysztof