linux-kernel - Re: [PATCH] checkpatch: Look for symbolic permissions and suggest octal instead

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1470184212.3998.211.camel@perches.com>
Date:	Tue, 02 Aug 2016 17:30:12 -0700
From:	Joe Perches <joe@...ches.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Andy Whitcroft <apw@...onical.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: Look for symbolic permissions and suggest
 octal instead

On Wed, 2016-08-03 at 01:15 +0100, Al Viro wrote:
> On Tue, Aug 02, 2016 at 04:39:24PM -0700, Joe Perches wrote:
> > 
> > S_ uses should be avoided where octal is more intelligible.
> Oh, for Cthulhu sake!  So not only we had been dribbled upon with 1200-odd
> piles of pointless crap, now we'll be getting yet another set of equally
> pointless garbage each time a bored wanker gets to run checkpatch.pl?
> 
> Leave that alone.  In either direction.  Dipshits on quest for commit count
> have enough tools already, no need to add another one...

Well, we disagree.

Use like DEVICE_ATTR are a mix of S_<FOO> vs octal (~3:1)
and a single style can be easier to grep for misuses.

Crud like this doesn't need to be cleaned up all at once and
checkpatch can be useful to encourage whatever preferred
style is desired.