linux-kernel - Re: [PATCH v3] virtio_blk: Fix a slient kernel panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <383B4F24-A757-4206-B251-04B9FBC4FBCD@alibaba-inc.com>
Date:	Thu, 4 Aug 2016 13:35:09 +0800
From:	Minfei Huang <minfei.hmf@...baba-inc.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>,
	Stefan Hajnoczi <stefanha@...il.com>
Cc:	Cornelia Huck <cornelia.huck@...ibm.com>, fanc.fnst@...fujitsu.com,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Linux Virtualization <virtualization@...ts.linux-foundation.org>
Subject: Re: [PATCH v3] virtio_blk: Fix a slient kernel panic

Hi, Michael.

Since Stefan and Cornelia have review-acked this patch, could you mind
helping review this patch?

Thanks
Minfei

> On Jul 29, 2016, at 16:26, Stefan Hajnoczi <stefanha@...il.com> wrote:
> 
> On Tue, Jul 19, 2016 at 5:32 AM, Minfei Huang <mnfhuang@...il.com> wrote:
>> From: Minfei Huang <mnghuan@...il.com>
>> 
>> We do a lot of memory allocation in function init_vq, and don't handle
>> the allocation failure properly. Then this function will return 0,
>> although initialization fails due to lacking memory. At that moment,
>> kernel will panic in guest machine, if virtio is used to drive disk.
>> 
>> To fix this bug, we should take care of allocation failure, and return
>> correct value to let caller know what happen.
>> 
>> Tested-by: Chao Fan <fanc.fnst@...fujitsu.com>
>> Signed-off-by: Minfei Huang <minfei.hmf@...baba-inc.com>
>> Signed-off-by: Minfei Huang <mnghuan@...il.com>
>> ---
>> v2:
>> - Remove useless initialisation to NULL
>> v1:
>> - Refactor the patch to make code more readable
>> ---
>> drivers/block/virtio_blk.c | 26 ++++++++------------------
>> 1 file changed, 8 insertions(+), 18 deletions(-)
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@...hat.com>


Download attachment "smime.p7s" of type "application/pkcs7-signature" (2353 bytes)