linux-kernel - Re: [patch] tty: amiserial.c: remove a double irq restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41427059-b5e4-1b30-e577-5a1cf3f81b29@suse.cz>
Date:	Thu, 4 Aug 2016 08:24:50 +0200
From:	Jiri Slaby <jslaby@...e.cz>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [patch] tty: amiserial.c: remove a double irq restore

On 08/04/2016, 07:34 AM, Dan Carpenter wrote:
> We already called "local_irq_restore(flags);" so this isn't needed.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
> index 208f573..2f33cf1 100644
> --- a/drivers/tty/amiserial.c
> +++ b/drivers/tty/amiserial.c
> @@ -880,7 +880,6 @@ static int rs_write(struct tty_struct * tty, const unsigned char *buf, int count

If I add a bit more context:

                local_irq_disable();
                custom.intena = IF_SETCLR | IF_TBE;
                mb();
>  		/* set a pending Tx Interrupt, transmitter should restart now */
>  		custom.intreq = IF_SETCLR | IF_TBE;
>  		mb();
> -		local_irq_restore(flags);

Really?

thanks,
-- 
js
suse labs