linux-kernel - Re: [PATCH] PM / devfreq: event: remove duplicate devfreq_event_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <57A2FF65.80704@samsung.com>
Date:	Thu, 04 Aug 2016 17:40:05 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Lin Huang <hl@...k-chips.com>
Cc:	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-rockchip@...ts.infradead.org,
	"함명주 (samsung.com)" 
	<myungjoo.ham@...sung.com>
Subject: Re: [PATCH] PM / devfreq: event: remove duplicate
 devfreq_event_get_drvdata()

+ Myungjoo Ham,

Hi Lin Huang,

On 2016년 08월 04일 15:01, Lin Huang wrote:
> there define two devfreq_event_get_drvdata() function in devfreq-event.h
> when disable CONFIG_PM_DEVFREQ_EVENT, it will lead to build fail. So
> remove devfreq_event_get_drvdata() function.
> 
> Signed-off-by: Lin Huang <hl@...k-chips.com>
> ---
>  include/linux/devfreq-event.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/include/linux/devfreq-event.h b/include/linux/devfreq-event.h
> index 0a83a1e..4db00b0 100644
> --- a/include/linux/devfreq-event.h
> +++ b/include/linux/devfreq-event.h
> @@ -148,11 +148,6 @@ static inline int devfreq_event_reset_event(struct devfreq_event_dev *edev)
>  	return -EINVAL;
>  }
>  
> -static inline void *devfreq_event_get_drvdata(struct devfreq_event_dev *edev)
> -{
> -	return ERR_PTR(-EINVAL);
> -}
> -
>  static inline struct devfreq_event_dev *devfreq_event_get_edev_by_phandle(
>  					struct device *dev, int index)
>  {
> 

Looks good to me.

Acked-by: Chanwoo Choi <cw00.choi@...sung.com>

Regards,
Chanwoo Choi