linux-kernel - Re: [PATCH] firmware_class: encapsulate firmware loading status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 4 Aug 2016 18:33:03 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Daniel Wagner <wagi@...om.org>
Cc:	kbuild-all@...org, Ming Lei <ming.lei@...onical.com>,
	linux-kernel@...r.kernel.org,
	Daniel Wagner <daniel.wagner@...-carit.de>,
	"Luis R . Rodriguez" <mcgrof@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] firmware_class: encapsulate firmware loading status

Hi Daniel,

[auto build test WARNING on v4.7-rc7]
[cannot apply to next-20160803]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Daniel-Wagner/firmware_class-encapsulate-firmware-loading-status/20160804-173551
config: cris-etrax-100lx_v2_defconfig (attached as .config)
compiler: cris-linux-gcc (GCC) 4.6.3
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=cris 

All warnings (new ones prefixed by >>):

>> drivers/base/firmware_class.c:1022:0: warning: "fw_status_is_aborted" redefined [enabled by default]
   drivers/base/firmware_class.c:158:0: note: this is the location of the previous definition
   drivers/base/firmware_class.c:115:22: warning: '__fw_status_get' defined but not used [-Wunused-function]

vim +/fw_status_is_aborted +1022 drivers/base/firmware_class.c

  1006				 __fw_load_abort(buf);
  1007		}
  1008		mutex_unlock(&fw_lock);
  1009	}
  1010	#endif
  1011	
  1012	#else /* CONFIG_FW_LOADER_USER_HELPER */
  1013	static inline int
  1014	fw_load_from_user_helper(struct firmware *firmware, const char *name,
  1015				 struct device *device, unsigned int opt_flags,
  1016				 long timeout)
  1017	{
  1018		return -ENOENT;
  1019	}
  1020	
  1021	/* No abort during direct loading */
> 1022	#define fw_status_is_aborted(buf) false
  1023	
  1024	#ifdef CONFIG_PM_SLEEP
  1025	static inline void kill_requests_without_uevent(void) { }
  1026	#endif
  1027	
  1028	#endif /* CONFIG_FW_LOADER_USER_HELPER */
  1029	
  1030	/* prepare firmware and firmware_buf structs;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (8254 bytes)