linux-kernel - Re: [PATCH 1/2] irqdomain: fix irq_domain_xlate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 4 Aug 2016 16:03:40 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Sebastian Frias <sf84@...oste.net>
cc:	Grant Likely <grant.likely@...retlab.ca>,
	Marc Zyngier <marc.zyngier@....com>,
	Jason Cooper <jason@...edaemon.net>,
	LKML <linux-kernel@...r.kernel.org>, Mason <slash.tmp@...e.fr>
Subject: Re: [PATCH 1/2] irqdomain: fix irq_domain_xlate_onetwocell()

On Thu, 4 Aug 2016, Sebastian Frias wrote:
> On 08/04/2016 12:05 PM, Thomas Gleixner wrote:
> (for what is worth, my patch was based on a recent 4.7 that does not has the
> code you mention above)

In future, please always check against mainline or the head of the relevant
maintainer tree.
 
> > So we better remove the masking in the xlate functions completely and let all
> > the offending device trees trip over the warning so they get eventually fixed.
> 
> That's fine by me.
> If you want I can submit a patch that does what you want (if so, should I use
> "fixes" or not?), let me know.

If it is broken then it wants a fixes tag plus an explanation WHY it is
broken, what consequences the breakage has etc.

If it's just a regular code improvement then not.

Decide yourself.

Thanks,

	tglx