linux-kernel - Re: [PATCH] Input: sis-i2c: select CONFIG_CRC_ITU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160804152005.GA5504@dtor-ws>
Date:	Thu, 4 Aug 2016 08:20:05 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Mika Penttilä <mika.penttila@...tfour.com>,
	Tammy Tseng <tammy_tseng@....com>, Yuger Yu <yuger_yu@....com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: sis-i2c: select CONFIG_CRC_ITU_T

On Thu, Aug 04, 2016 at 03:07:06PM +0200, Arnd Bergmann wrote:
> The newly added sis_i2c driver fails to link without the CRC_ITU_T
> driver enabled:
> 
> drivers/input/touchscreen/sis_i2c.o: In function `sis_ts_irq_handler':
> sis_i2c.c:(.text+0xc0): undefined reference to `crc_itu_t'
> 
> This adds a Kconfig select statement.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: a485cb037fe6 ("Input: add driver for SiS 9200 family I2C touchscreen controllers")

Thank you Arnd.

> ---
>  drivers/input/touchscreen/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
> index 8d893cefb0e3..2fb1f430a431 100644
> --- a/drivers/input/touchscreen/Kconfig
> +++ b/drivers/input/touchscreen/Kconfig
> @@ -1074,6 +1074,7 @@ config TOUCHSCREEN_SILEAD
>  config TOUCHSCREEN_SIS_I2C
>  	tristate "SiS 9200 family I2C touchscreen"
>  	depends on I2C
> +	select CRC_ITU_T
>  	depends on GPIOLIB || COMPILE_TEST
>  	help
>  	  This enables support for SiS 9200 family over I2C based touchscreens.
> -- 
> 2.9.0
> 

-- 
Dmitry