[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160804151102.GR6862@twins.programming.kicks-ass.net>
Date: Thu, 4 Aug 2016 17:11:02 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: David Carrillo-Cisneros <davidcc@...gle.com>
Cc: linux-kernel@...r.kernel.org, "x86@...nel.org" <x86@...nel.org>,
Ingo Molnar <mingo@...hat.com>,
Thomas Gleixner <tglx@...utronix.de>,
Andi Kleen <ak@...ux.intel.com>,
Kan Liang <kan.liang@...el.com>, Paul Turner <pjt@...gle.com>,
Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 2/3] perf/core: introduce pmu_event_flags and
PMUEF_READ_CPU_PKG
On Mon, Aug 01, 2016 at 07:44:54PM -0700, David Carrillo-Cisneros wrote:
> +/*
> + * Flags for pmu_event_flags.
> + *
> + * PMUEF_READ_CPU_PKG: A CPU event (or cgroup event) that can be read in
> + * any CPU in event->cpu's package, even if inactive.
> + */
> +#define PMUEF_READ_CPU_PKG BIT(0)
So I don't object to the idea, but this flags thing seems somewhat
awkward to express 'random' topology constraints.
For example, the AMD Fam15 NB driver could use something similar, but
I'm not sure their NB-id matches our topo package id.
Powered by blists - more mailing lists