linux-kernel - Re: [PATCH 37/45] drivers: use req op accessor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJVOszAqEw3UK6HV4bPvYfHeO6jvP0d-OtfXxRuve=5-Kmaokw@mail.gmail.com>
Date:	Thu, 4 Aug 2016 11:32:16 -0500
From:	Shaun Tancheff <shaun.tancheff@...gate.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Mike Christie <mchristi@...hat.com>, philipp.reisner@...bit.com,
	dm-devel@...hat.com, target-devel@...r.kernel.org,
	linux-mtd@...ts.infradead.org, drbd-dev@...ts.linbit.com,
	linux-scsi@...r.kernel.org,
	Ross Zwisler <ross.zwisler@...ux.intel.com>,
	linux-ext4 <linux-ext4@...r.kernel.org>, konrad.wilk@...cle.com,
	XFS Developers <xfs@....sgi.com>, linux-raid@...r.kernel.org,
	linux-bcache@...r.kernel.org, linux-block@...r.kernel.org,
	osd-dev@...n-osd.org, Ross Zwisler <zwisler@...il.com>,
	Jens Axboe <axboe@...com>, LKML <linux-kernel@...r.kernel.org>,
	linux-f2fs-devel@...ts.sourceforge.net, ocfs2-devel@....oracle.com,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	lars.ellenberg@...bit.com, linux-btrfs@...r.kernel.org
Subject: Re: [PATCH 37/45] drivers: use req op accessor

On Thu, Aug 4, 2016 at 10:46 AM, Christoph Hellwig <hch@...radead.org> wrote:
> On Wed, Aug 03, 2016 at 07:30:29PM -0500, Shaun Tancheff wrote:
>> I think the translation in loop.c is suspicious here:
>>
>>     "if use DIO && not (a flush_flag or discard_flag)"
>> should translate to:
>>     "if use DIO && not ((a flush_flag) || op == discard)"
>>
>> But in the patch I read:
>>     "if use DIO && ((not a flush_flag) || op == discard)
>>
>> Which would have DIO && discards follow the AIO path?
>
> Indeed.  Sorry for missing out on your patch, I just sent a fix
> in reply to Dave's other report earlier which is pretty similar to
> yours.

No worries. I prefer your switch to a an if conditional here.

-- 
Shaun Tancheff