linux-kernel - Re: [RFC][PATCH 2/4] dt-bindings: power: reset: Add document for sram-reboot-mode driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160804180852.GA5967@rob-hp-laptop>
Date:	Thu, 4 Aug 2016 13:08:52 -0500
From:	Rob Herring <robh@...nel.org>
To:	John Stultz <john.stultz@...aro.org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Andy Yan <andy.yan@...k-chips.com>,
	Arnd Bergmann <arnd@...db.de>,
	Thierry Reding <treding@...dia.com>,
	Heiko Stübner <heiko@...ech.de>,
	Caesar Wang <wxt@...k-chips.com>,
	Kees Cook <keescook@...omium.org>,
	Guodong Xu <guodong.xu@...aro.org>,
	Haojian Zhuang <haojian.zhuang@...aro.org>,
	Vishal Bhoj <vishal.bhoj@...aro.org>,
	Bjorn Andersson <bjorn.andersson@...aro.org>,
	devicetree@...r.kernel.org,
	Android Kernel Team <kernel-team@...roid.com>
Subject: Re: [RFC][PATCH 2/4] dt-bindings: power: reset: Add document for
 sram-reboot-mode driver

On Wed, Aug 03, 2016 at 04:05:21PM -0700, John Stultz wrote:
> Add device tree binding document for reboot-mode driver
> 
> Cc: Andy Yan <andy.yan@...k-chips.com>
> Cc: Rob Herring <robh@...nel.org>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Thierry Reding <treding@...dia.com>
> Cc: Heiko Stübner <heiko@...ech.de>
> Cc: Caesar Wang <wxt@...k-chips.com>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Guodong Xu <guodong.xu@...aro.org>
> Cc: Haojian Zhuang <haojian.zhuang@...aro.org>
> Cc: Vishal Bhoj <vishal.bhoj@...aro.org>
> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> Cc: devicetree@...r.kernel.org
> Cc: Android Kernel Team <kernel-team@...roid.com>
> Signed-off-by: John Stultz <john.stultz@...aro.org>
> ---
>  .../bindings/power/reset/sram-reboot-mode.txt      | 35 ++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/reset/sram-reboot-mode.txt
> 
> diff --git a/Documentation/devicetree/bindings/power/reset/sram-reboot-mode.txt b/Documentation/devicetree/bindings/power/reset/sram-reboot-mode.txt
> new file mode 100644
> index 0000000..0a0ed05
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/reset/sram-reboot-mode.txt
> @@ -0,0 +1,35 @@
> +SRAM reboot mode driver

Bindings don't describe drivers.

> +
> +This driver get reboot mode magic value form reboot-mode driver

s/form/from/

> +and stores it in a SRAM address. Then the bootloader
> +can read it and take different action according to the magic
> +value stored.

Might say "on the next reboot" somewhere in here.

> +
> +This DT node should be represented as a sub-node of a "mmio-sram" node.
> +
> +Required properties:
> +- compatible: should be "sram-reboot-mode"
> +- reg: offset from the sram range where to store the magic value(in bytes)
> +
> +The rest of the properties should follow the generic reboot-mode discription
> +found in reboot-mode.txt
> +
> +Example:
> +
> +	sram@...1000 {
> +		compatible = "mmio-sram";
> +		reg = <0x0 0x05f01000 0x0 0x00001000>;
> +		ranges = <0x0 0x0 0x05f01000 0x00001000>;
> +
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +
> +		reboot-mode@0 {
> +			compatible = "sram-reboot-mode";
> +			reg = <0x0 0x4>;
> +
> +			mode-normal     = <0x77665501>;
> +			mode-bootloader = <0x77665500>;
> +			mode-recovery   = <0x77665502>;
> +		};
> +	};
> -- 
> 1.9.1
>