linux-kernel - Re: [PATCH v3 2/4] rtc: rtc-pm8xxx: Add support for pm8018 rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <97671c78-d7ad-9cef-f647-6e7cc8b9234e@codeaurora.org>
Date:	Thu, 4 Aug 2016 14:58:09 -0700
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Neil Armstrong <narmstrong@...libre.com>, andy.gross@...aro.org,
	david.brown@...aro.org, lee.jones@...aro.org, lgirdwood@...il.com,
	broonie@...nel.org, a.zummo@...ertech.it,
	alexandre.belloni@...e-electrons.com
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
	rtc-linux@...glegroups.com
Subject: Re: [PATCH v3 2/4] rtc: rtc-pm8xxx: Add support for pm8018 rtc

On 07/19/2016 06:51 AM, Neil Armstrong wrote:
> diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c
> index 795fcbd..976f5f6 100644
> --- a/drivers/rtc/rtc-pm8xxx.c
> +++ b/drivers/rtc/rtc-pm8xxx.c
> @@ -393,6 +393,16 @@ static int pm8xxx_rtc_enable(struct pm8xxx_rtc *rtc_dd)
>  	return 0;
>  }
>  
> +static const struct pm8xxx_rtc_regs pm8018_regs = {
> +	.ctrl		= 0x11d,
> +	.write		= 0x11f,
> +	.read		= 0x123,
> +	.alarm_rw	= 0x127,
> +	.alarm_ctrl	= 0x11d,
> +	.alarm_ctrl2	= 0x11e,
> +	.alarm_en	= BIT(1),
> +};

This is the same as pm8921_regs, so why do we need to duplicate it?
Can't we point the new compatible at the same data?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project