linux-kernel - Re: [PATCH v2] powerpc/32: fix csum_partial_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87eg63imi8.fsf@concordia.ellerman.id.au>
Date:	Fri, 05 Aug 2016 19:38:23 +1000
From:	Michael Ellerman <mpe@...erman.id.au>
To:	Christophe Leroy <christophe.leroy@....fr>,
	Alessio Igor Bogani <alessio.bogani@...ttra.eu>,
	Scott Wood <oss@...error.net>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	LKML <linux-kernel@...r.kernel.org>,
	linuxppc-dev@...ts.ozlabs.org, stable@...r.kernel.org,
	antoine.blangy@....fr, segher@...nel.crashing.org
Subject: Re: [PATCH v2] powerpc/32: fix csum_partial_copy_generic()

Christophe Leroy <christophe.leroy@....fr> writes:

> Le 05/08/2016 à 08:57, Michael Ellerman a écrit :
>> Alessio Igor Bogani <alessio.bogani@...ttra.eu> writes:
>>> On 4 August 2016 at 05:53, Scott Wood <oss@...error.net> wrote:
>>>> On Tue, 2016-08-02 at 10:07 +0200, Christophe Leroy wrote:
>>>>> commit 7aef4136566b0 ("powerpc32: rewrite csum_partial_copy_generic()
>>>>> based on copy_tofrom_user()") introduced a bug when destination
>>>>> address is odd and initial csum is not null
>>>>>
>
> The purpose of this patch was not to address Alessio's issue, but to fix 
> a huge issue on checksum calculation which induces breakdown of TCP 
> connections.
>
> I think it is worth commiting it upstream and on impacted stable 
> releases, allthought we don't have yet identified the issue Alessio's has.

OK. I'll put it back into fixes on Monday if I haven't heard anything
further.

cheers