linux-kernel - Re: [PATCH 08/11] net/fsl: use of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1608051207510.2999@hadrien>
Date:	Fri, 5 Aug 2016 12:08:35 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Johannes Berg <johannes@...solutions.net>
cc:	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/11] net/fsl: use of_property_read_bool



On Fri, 5 Aug 2016, Johannes Berg wrote:

>
> > -	if (of_get_property(pdev->dev.of_node,
> > -			    "little-endian", NULL))
> > +	if (of_property_read_bool(pdev->dev.of_node, "little-
> > endian"))
> >  		priv->is_little_endian = true;
> >  	else
> >  		priv->is_little_endian = false;
> >
>
> Perhaps, while changing this, that'd be better as
>
> 	priv->is_little_endian = of_property_read_bool(...);
>
> Obviously that would've worked before, but now it'd be even easier to
> understand, it seems.

Can I do the same for:

	if (of_property_read_bool(np, "phy-clk-valid"))
                pdata->check_phy_clk_valid = 1;
	else
                pdata->check_phy_clk_valid = 0;

The type is not bool, but:

include/linux/fsl_devices.h:    unsigned        check_phy_clk_valid:1;

thanks,
julia