linux-kernel - Re: [PATCH 08/11] net/fsl: use of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 5 Aug 2016 12:14:19 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Johannes Berg <johannes@...solutions.net>
cc:	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/11] net/fsl: use of_property_read_bool



On Fri, 5 Aug 2016, Johannes Berg wrote:

> On Fri, 2016-08-05 at 12:08 +0200, Julia Lawall wrote:
> > 
> > Can I do the same for:
> >
> >         if (of_property_read_bool(np, "phy-clk-valid"))
> >                 pdata->check_phy_clk_valid = 1;
> >         else
> >                 pdata->check_phy_clk_valid = 0;
> >
> > The type is not bool, but:
> >
> > include/linux/fsl_devices.h:    unsigned        check_phy_clk_valid:1;
> >
> The type doesn't even matter, does it? Any bool->int conversion should
> result in 0/1.

Just paranoid.  Thanks.

julia