linux-kernel - Re: [PATCH v2] efi: capsule: allocate whole capsule into virtual memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160805114653.GP3636@codeblueprint.co.uk>
Date:	Fri, 5 Aug 2016 12:46:53 +0100
From:	Matt Fleming <matt@...eblueprint.co.uk>
To:	Austin Christ <austinwc@...eaurora.org>
Cc:	linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, jbrasen@...eaurora.org
Subject: Re: [PATCH v2] efi: capsule: allocate whole capsule into virtual
 memory

On Thu, 28 Jul, at 03:30:29PM, Christ, Austin wrote:
> According to UEFI 2.6 section 7.5.3, the capsule should be in contiguous
> virtual memory and firmware may consume the capsule immediately. To
> correctly implement this functionality, the kernel driver needs to vmap
> the entire capsule at the time it is made available to firmware.
> 
> The virtual allocation of the capsule update has been changed from kmap,
> which was only allocating the first page of the update, to vmap, and
> allocates the entire data payload.
> 
> Signed-off-by: Austin Christ <austinwc@...eaurora.org>
> Reviewed-by: Matt Fleming <matt@...eblueprint.co.uk>
> Reviewed-by: Lee, Chun-Yi <jlee@...e.com>
> ---
>  drivers/firmware/efi/capsule-loader.c | 8 +++++---
>  drivers/firmware/efi/capsule.c        | 6 +++---
>  2 files changed, 8 insertions(+), 6 deletions(-)

Thanks, applied.