linux-kernel - Re: [PATCH v5] sched/deadline: remove useless param from setup_new_dl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 5 Aug 2016 10:54:08 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Juri Lelli <juri.lelli@....com>
Cc:	peterz@...radead.org, linux-kernel@...r.kernel.org,
	mingo@...hat.com, luca.abeni@...tn.it, xpang@...hat.com
Subject: Re: [PATCH v5] sched/deadline: remove useless param from
 setup_new_dl_entity

On Fri, 5 Aug 2016 15:34:44 +0100
Juri Lelli <juri.lelli@....com> wrote:

> On 05/08/16 09:56, Steven Rostedt wrote:
> > On Fri,  5 Aug 2016 11:09:59 +0100
> > Juri Lelli <juri.lelli@....com> wrote:
> >   
> > > @@ -1720,19 +1720,28 @@ static void switched_from_dl(struct rq *rq, struct task_struct *p)
> > >   */
> > >  static void switched_to_dl(struct rq *rq, struct task_struct *p)
> > >  {
> > > -	if (dl_time_before(p->dl.deadline, rq_clock(rq)))
> > > -		setup_new_dl_entity(&p->dl, &p->dl);
> > >  
> > > -	if (task_on_rq_queued(p) && rq->curr != p) {
> > > +	if (task_on_rq_queued(p)) {  
> > 
> > I always hated functions totally encapsulated by an if statement. This
> > can be a bit simpler (and less indented) if you have:
> > 
> > 	/* If p is not queued, its parameters will be updated at wakeup */
> > 	if (!task_on_rq_queued(p))
> > 		return;
> > 
> > 	[...]
> >   
> 
> You mean like what follows?
> 
> I'll post a v6 if OK.
> 

Yes! I think that looks much nicer, and easier to read.

You can add my Reviewed-by tag too.

Thanks!

-- Steve