linux-kernel - Re: [PATCH] mfd: altera-a10sr: Make altr_a10sr_regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1dcbbd8-d3fb-9b6f-9062-37ddc823cb51@opensource.altera.com>
Date:	Fri, 5 Aug 2016 08:58:55 -0500
From:	Thor Thayer <tthayer@...nsource.altera.com>
To:	Axel Lin <axel.lin@...ics.com>, Lee Jones <lee.jones@...aro.org>
CC:	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: altera-a10sr: Make altr_a10sr_regmap_config static
 const



On 08/05/2016 01:40 AM, Axel Lin wrote:
> It's only used in this driver and never get modified, make it static const.
>
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>  drivers/mfd/altera-a10sr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c
> index c05aa4f..40ed65e 100644
> --- a/drivers/mfd/altera-a10sr.c
> +++ b/drivers/mfd/altera-a10sr.c
> @@ -94,7 +94,7 @@ static bool altr_a10sr_reg_volatile(struct device *dev, unsigned int reg)
>  	}
>  }
>
> -const struct regmap_config altr_a10sr_regmap_config = {
> +static const struct regmap_config altr_a10sr_regmap_config = {
>  	.reg_bits = 8,
>  	.val_bits = 8,
>
>
Reviewed-by: Thor Thayer <tthayer@...nsource.altera.com>