linux-kernel - Re: [PATCH V3 1/6] perf/core: Adding PMU driver specific configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160805155344.GV6879@twins.programming.kicks-ass.net>
Date:	Fri, 5 Aug 2016 17:53:44 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Mathieu Poirier <mathieu.poirier@...aro.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>, jolsa@...nel.org,
	Ingo Molnar <mingo@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Vince Weaver <vince@...ter.net>,
	"Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>
Subject: Re: [PATCH V3 1/6] perf/core: Adding PMU driver specific
 configuration

On Fri, Aug 05, 2016 at 09:35:05AM -0600, Mathieu Poirier wrote:
> On 4 August 2016 at 10:58, Peter Zijlstra <peterz@...radead.org> wrote:
> > On Thu, Jul 28, 2016 at 03:42:18PM -0600, Mathieu Poirier wrote:
> >> This patch somewhat mimics the work done on address filters to
> >> add the infrastructure needed to pass PMU specific HW
> >> configuration to the driver before a session starts.
> >>
> >> Signed-off-by: Mathieu Poirier <mathieu.poirier@...aro.org>
> >
> >> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
> >> index c66a485a24ac..90fbc5fd3925 100644
> >> --- a/include/uapi/linux/perf_event.h
> >> +++ b/include/uapi/linux/perf_event.h
> >> @@ -407,6 +407,7 @@ struct perf_event_attr {
> >>  #define PERF_EVENT_IOC_ID            _IOR('$', 7, __u64 *)
> >>  #define PERF_EVENT_IOC_SET_BPF               _IOW('$', 8, __u32)
> >>  #define PERF_EVENT_IOC_PAUSE_OUTPUT  _IOW('$', 9, __u32)
> >> +#define PERF_EVENT_IOC_SET_DRV_CONFIGS       _IOW('$', 10, char *)
> >
> > Please also do a manpages patch.
> 
> Patch 3/6 in this set documents the new option
> (tools/perf/Documentation/perf-record.tx).  Is this what you were
> looking for?  If not please expand on the information you want to see
> added add and where.

Since you add an IOCTL (with preferably more structure than present in
this patch, see the other email) this needs to be documented in the
syscall manpage.

  http://git.kernel.org/cgit/docs/man-pages/man-pages.git/tree/man2/perf_event_open.2

  http://www.man7.org/linux/man-pages/man2/perf_event_open.2.html