linux-kernel - Re: [PATCH v2 13/44] x86/asm/head: remove useless zeroed word

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160805162305.ykzdfkchzqwwy5cg@treble>
Date:	Fri, 5 Aug 2016 11:23:05 -0500
From:	Josh Poimboeuf <jpoimboe@...hat.com>
To:	Brian Gerst <brgerst@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...nel.org>,
	"H . Peter Anvin" <hpa@...or.com>,
	the arch/x86 maintainers <x86@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andy Lutomirski <luto@...capital.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Kees Cook <keescook@...omium.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Byungchul Park <byungchul.park@....com>
Subject: Re: [PATCH v2 13/44] x86/asm/head: remove useless zeroed word

On Fri, Aug 05, 2016 at 12:13:04PM -0400, Brian Gerst wrote:
> On Thu, Aug 4, 2016 at 6:22 PM, Josh Poimboeuf <jpoimboe@...hat.com> wrote:
> > This zeroed word has no apparent purpose, so remove it.
> >
> > Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
> > ---
> >  arch/x86/kernel/head_64.S | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/x86/kernel/head_64.S b/arch/x86/kernel/head_64.S
> > index 8822c20..ac6e27e 100644
> > --- a/arch/x86/kernel/head_64.S
> > +++ b/arch/x86/kernel/head_64.S
> > @@ -326,7 +326,6 @@ ENDPROC(start_cpu0)
> >         .quad   INIT_PER_CPU_VAR(irq_stack_union)
> >         GLOBAL(initial_stack)
> >         .quad  init_thread_union+THREAD_SIZE-8
> > -       .word  0
> >         __FINITDATA
> >
> >  bad_address:
> 
> 
> FYI the word used to be the SS segment selector for the LSS
> instruction, which isn't needed in 64-bit mode.

Thanks.  I'll add that info to the patch header.

-- 
Josh