linux-kernel - Re: kernel/printk/printk.c: Invalid access when buffer wraps around?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <82e4f649-0e06-df57-d7ef-3f42bb633644@cern.ch>
Date:	Fri, 5 Aug 2016 07:14:38 +0200
From:	Vincent Brillault <vincent.brillault@...n.ch>
To:	Ivan Delalande <colona@...sta.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Petr Mladek <pmladek@...e.com>,
	Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
	Andrey Ryabinin <aryabinin@...tuozzo.com>,
	Kees Cook <keescook@...omium.org>,
	Thierry Reding <treding@...dia.com>,
	Geliang Tang <geliangtang@....com>, Tejun Heo <tj@...nel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: kernel/printk/printk.c: Invalid access when buffer wraps around?

Dear Ivan, all

Sorry for the delay, I currently have limited internet access.

> Thanks for your very detailled write-up but I believe you are mistaken
> on the value of log_first_idx between these two last steps you describe.

After re-reading log_next and log_make_free_space, I believe that you
are right and that I was wrong. Your explanation is crystal-clear and I
now don't understand how I missed this (it's even explained in the
comments...). This means that we might be removing the first element in
the buffer while there was enough space to store it at the end of the
buffer, but I guess this is better than having a bug ;)

I'm sorry for the noise everyone. Thank you for your patience and great
explanation.

Sincerely yours,
Vincent Brillault

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)