linux-kernel - Re: [PATCH v2 04/22] usb: chipidea: Only read/write OTGSC from one place

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20160806074258.GA12298@shlinux2>
Date:	Sat, 6 Aug 2016 15:42:58 +0800
From:	Peter Chen <hzpeterchen@...il.com>
To:	Stephen Boyd <stephen.boyd@...aro.org>
Cc:	linux-usb@...r.kernel.org, Felipe Balbi <balbi@...nel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Neil Armstrong <narmstrong@...libre.com>,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Bjorn Andersson <bjorn.andersson@...aro.org>,
	Peter Chen <peter.chen@....com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Andy Gross <andy.gross@...aro.org>,
	"Ivan T. Ivanov" <iivanov.xz@...il.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 04/22] usb: chipidea: Only read/write OTGSC from one
 place

On Fri, Aug 05, 2016 at 02:41:37PM -0700, Stephen Boyd wrote:
> Quoting Peter Chen (2016-07-08 02:14:57)
> > On Thu, Jul 07, 2016 at 03:20:55PM -0700, Stephen Boyd wrote:
> > > diff --git a/drivers/usb/chipidea/otg.c b/drivers/usb/chipidea/otg.c
> > > index 03b6743461d1..a6fc60934297 100644
> > > --- a/drivers/usb/chipidea/otg.c
> > > +++ b/drivers/usb/chipidea/otg.c
> > > @@ -104,7 +104,31 @@ void ci_handle_vbus_change(struct ci_hdrc *ci)
> > >               usb_gadget_vbus_disconnect(&ci->gadget);
> > >  }
> > >  
> > > -#define CI_VBUS_STABLE_TIMEOUT_MS 5000
> > > +/**
> > > + * When we switch to device mode, the vbus value should be lower
> > > + * than OTGSC_BSV before connecting to host.
> > > + *
> > > + * @ci: the controller
> > > + *
> > > + * This function returns an error code if timeout
> > > + */
> > > +static int hw_wait_otgsc_bsv(struct ci_hdrc *ci)
> > 
> > I think the function name should reflect "we wait for vbus lower than bsv"
> > Care to change one?
> > 
> 
> Sure, something like hw_wait_vbus_lower_bsv()?

Agree.

-- 

Best Regards,
Peter Chen