linux-kernel - Re: [PATCH v3 2/3] drm: Add API for capturing frame CRCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPj87rPebR2E44ReR93SSVgENPXKZqqj6F6S-bcQ8a+njc9PFQ@mail.gmail.com>
Date:	Sat, 6 Aug 2016 18:04:06 +0100
From:	Daniel Stone <daniel@...ishbar.org>
To:	Tomeu Vizoso <tomeu.vizoso@...labora.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-doc@...r.kernel.org, Jonathan Corbet <corbet@....net>,
	dri-devel <dri-devel@...ts.freedesktop.org>,
	Daniel Vetter <daniel.vetter@...el.com>,
	Emil Velikov <emil.velikov@...labora.com>
Subject: Re: [PATCH v3 2/3] drm: Add API for capturing frame CRCs

Hi Tomeu,

On 22 July 2016 at 15:10, Tomeu Vizoso <tomeu.vizoso@...labora.com> wrote:
> +/**
> + * DOC: CRC ABI
> + *
> + * DRM device drivers can provide to userspace CRC information of each frame as
> + * it reached a given hardware component (a "source").
> + *
> + * Userspace can control generation of CRCs in a given CRTC by writing to the

s/can/must/

Is it worth having 'auto' as a default source perhaps?

> + * file dri/0/crtc-N/crc/control in debugfs, with N being the index of the CRTC.
> + * Accepted values are source names (which are driver-specific) and the "none"
> + * and "auto" keywords. "none" will disable CRC generation and "auto" will let
> + * the driver select a default source of frame CRCs for this CRTC.

Is it also worth having 'connector-%s' (named as per sysfs, e.g.
connector-HDMI-A-0) as a standardised entry, for cloneable CRTCs which
have CRC control on the connector rather than the CRTC?

Cheers,
Daniel